Fixing deprecation warning Wdeprecated-literal-operator on LLVM 16.0.6 #2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All source code under the directory |
|
Rejected this change in fmt: fmtlib/fmt#3608 Current PR: fmtlib/fmt#3610 |
|
Thanks for the heads up. Sounds like this change is redundant then, so we can probably close? |
|
Yes. close it. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://reviews.llvm.org/rG5ce5e983f82c802e44faa8ed42d605d70c045ba9
Since LLVM 16.0.6 (which I am using via Emscripten), the following code can generate a warning due to use the deprecated syntax of the literal operator.
This fixed the issue in my project. Please let me know if my PR is improperly formatted or there's anything else I need to do.