Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INSTALL.md has been updated to provide current status information. #3052

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

KaganCanSit
Copy link
Contributor

@KaganCanSit KaganCanSit commented Mar 22, 2024

The purpose of this regulation is to better inform the user about many current issues.

Spdlog uses fmt repository directly. Compilation errors occurring in file contents obtained from this repository are not handled by the spd community. (Consider the cost and complexity of retroactive support.)

You can read general information about this issue in the issue content (#3050)

! Note:

  • Minimum gcc version information and requirements can be discovered later.

@gabime
Copy link
Owner

gabime commented Mar 22, 2024

Instead of removing this info, lwts find which min version do work. Also the fmt warning belongs to the wiki FAQ instead of main readme.

@KaganCanSit
Copy link
Contributor Author

@gabime Thanks for the guidance. I can remove the fmt warning from install.md. Or it could be in two places. I don't know. It's your decision.

Unfortunately, I do not have an environment where I can try GCC versions. If there is a tool for this, can you share it? Or if you have the information, let's update the test section.

If you direct me, I can take care of it in my free time.

@gabime
Copy link
Owner

gabime commented Mar 23, 2024

Yes, please remove the fmt warning from install.md. It belongs to the wiki.
Regarding trying gcc versions, the easiest is use gcc docker images (e.g https://hub.docker.com/_/gcc/tags?page=1&name=4.8 or https://hub.docker.com/_/gcc/tags?page=1&name=4.9).

@KaganCanSit
Copy link
Contributor Author

@gabime I made the necessary changes to INSTALL.md. Now I will write the gcc versions I tried in the issue. Let other people find it when they search for it. I may have made a mistake while testing. I haven't used Docker much!

@gabime gabime merged commit c9ce17a into gabime:v1.x Mar 23, 2024
1 check passed
@gabime
Copy link
Owner

gabime commented Mar 23, 2024

Thanks @KaganCanSit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants