-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: draft freehand highlighter #77
Conversation
I think (not a dev, just a random user) that it should probably be an option you can set in the config file. |
yeah that's probably best, i'll get to working on this in a few days so it can finally not be a draft |
I agree.. I didn't have a look at the PR, @DerpDays let me know if I can help |
Sorry for the large delay & also the large commit (this should have been broken down into quite a few more commits). This should mostly ready, here's an overview of the new things:
Let me know if there's anything that needs changing or can be done better. |
If you start holding shift mid-way should it draw a straight line from the beginning or from the spot you started holding shift from (it does latter rn)? |
The spot you started holding shift from, thought it'd give more options for how people want to draw it, since you can just hold shift when starting the highlight to achieve the other effect |
I just tested it, it looks great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please adress the comments above, then we are good to go! Great contribution 🎉
Thank you for this great contribution 🥳 |
This is will add a freehand highlighter as the default (with shift to align it), and then have a selection highlight (like there currently is) accessible by pressing ctrl whilst on the highlighter, since this was suggested at some point (though since currently the highlighter tool is the selection it might make more sense to make the freehand one accessible through ctrl instead), currently this is just draft and needs quite a bit of cleanup.
EDIT: kept the block/selection highlighter as the default, with the freehand/line highlighter being the alternative highlighter, this is configurable via the CLI or config.