feat: Add support for Modal on iOS when Fabric is enabled #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
changed the title
gabrieldonadel
force-pushed
the
feat/add-modal-host-view
branch
from
0e4f41e
to
5839c56
Compare
|
Tracked on https://github.com/facebook/react-native/pull/ 34487 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working on a fix for https://github.com/facebook/react-native/issues/ 29974 ( I have a draft for that already (https://github.com/gabrieldonadel/react-native/pull/ 16), just waiting for https://github.com/facebook/react-native/pull/ 34406 to get merged ) I noticed that the
KeyboardAvoidingViewtests on RNTester on iOS were not working with Fabric enabled becauseModalHostViewcomponent was still not implemented. Upon some more investigation, I found this code suggestion from Milker90 (https://github.com/facebook/react-native/issues/ 33652#issuecomment-1214675790) that enables the Modal component on iOS when Fabric is enabled.Closes https://github.com/facebook/react-native/issues/ 33652
Changelog
[iOS] [Added] - Add support for Modal on iOS when Fabric is enabled
Test Plan
Modalcomponent through the sections changing propsScreen.Recording.2022-08-23.at.21.29.51.mov