Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool cache fixes #321

Merged
merged 2 commits into from
May 13, 2022
Merged

Tool cache fixes #321

merged 2 commits into from
May 13, 2022

Conversation

ursetto
Copy link
Contributor

@ursetto ursetto commented Feb 25, 2022

This fixes a couple bugs in the tool cache:

  • pyenv-archive.zip will not be redownloaded if it is already cached.
  • pyenv_root will not be recreated (through reinstalling pyenv) if it is already cached. This avoids wiping out links to previously cached python installs, causing jobs to fail on persistent runners.

One of the integration tests is modified to use this action twice in the same job, which triggers the bug in the old code but is fixed by this PR. A persistent runner is not needed for this test.

The npm tests are left alone, as they do not currently install or test any python version after installing pyenv, and that's the only way to trigger a failure.

Resolves #320.

@ursetto ursetto mentioned this pull request Apr 8, 2022
@gabrielfalcao
Copy link
Owner

Hey this is awesome!
Thanks for the PR.

I didn't think other human beings beside myself found much utility for this github action because most of the PRs I'd seen come from bots.
With that said, I'm wondering if you and @blakewatters would like to start a tiny community to maintain this and I'd move the project out of my personal account into a github org.

In the mean time I'll just merge both of your PRs and make a new release.

Thanks!

@gabrielfalcao gabrielfalcao merged commit 6ccd3ac into gabrielfalcao:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tool cache is not working
2 participants