fix: typeCallConfig not generating correct types for resultProp

fix #70

libs/ngrx-traits/signals/src/lib/with-calls/with-calls.spec.ts

@@ -143,5 +143,39 @@ describe('withCalls', () => {
         expect(store.foo()).toBe('test');
       });
     });
+
+    it('check typedCallConfig with resultProp generates custom prop name ', async () => {
+      TestBed.runInInjectionContext(() => {
+        const Store = signalStore(
+          withState({ foo: 'bar' }),
+          withCalls((store) => ({
+            testCall: typedCallConfig({
+              call: ({ ok }: { ok: boolean }) => {
+                return ok
+                  ? apiResponse
+                  : apiResponse.pipe(
+                      tap(() => throwError(() => new Error('fail'))),
+                    );
+              },
+              resultProp: 'baz',
+              onSuccess: (result) => {
+                // patchState should be able to update the store inside onSuccess
+                patchState(store, { foo: result });
+              },
+              onError,
+            }),
+          })),
+        );
+        const store = new Store();
+        expect(store.isTestCallLoading()).toBeFalsy();
+        store.testCall({ ok: true });
+        expect(store.isTestCallLoading()).toBeTruthy();
+        apiResponse.next('test');
+        expect(store.isTestCallLoaded()).toBeTruthy();
+        expect((store as any).testCallResult).toBeUndefined();
+        expect(store.foo()).toBe('test');
+        expect(store.baz()).toBe('test');
+      });
+    });
   });
 });

libs/ngrx-traits/signals/src/lib/with-calls/with-calls.ts

@@ -109,13 +109,13 @@ export function withCalls<
   ) => Calls,
 ): SignalStoreFeature<
   Input,
-  Input & {
+  {
     state: NamedCallStatusState<keyof Calls & string> & {
       [K in keyof Calls as Calls[K] extends CallConfig
         ? Calls[K]['storeResult'] extends false
           ? never
-          : Calls[K]['resultProp'] extends string
-            ? Calls[K]['resultProp']
+          : Calls[K]['resultProp'] extends string | undefined
+            ? Calls[K]['resultProp'] & string
             : `${K & string}Result`
         : `${K & string}Result`]: ExtractCallResultType<Calls[K]> | undefined;
     };
@@ -286,6 +286,13 @@ export function typedCallConfig<
   Params extends readonly any[] = any[],
   Result = any,
   PropName extends string = string,
->(config: CallConfig<Params, Result, PropName>) {
-  return config;
+  C extends CallConfig<Params, Result, PropName> = CallConfig<
+    Params,
+    Result,
+    PropName
+  >,
+>(config: CallConfig<Params, Result, PropName>): C {
+  // this fixes weird issue where typedCallConfig was not generating the right types
+  // when CallConfig resultProp was defined
+  return { ...config } as C;
 }

tsconfig.base.json

@@ -7,6 +7,7 @@
     "moduleResolution": "node",
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
+    "noErrorTruncation": true,
     "importHelpers": true,
     "target": "es2015",
     "module": "esnext",