fix(signals): fix clearEntitiesCache for remote scroll pagination

clearEntitiesCache was not reseting the state correctly Fix #128
gabrielguerrero · Aug 29, 2024 · 880acef · 880acef
1 parent 0572475
commit 880acef
Show file tree

Hide file tree

Showing 2 changed files with 77 additions and 0 deletions.
diff --git a/...s/signals/src/lib/with-entities-pagination/with-entities-remote-scroll-pagination.spec.ts b/...s/signals/src/lib/with-entities-pagination/with-entities-remote-scroll-pagination.spec.ts
@@ -594,6 +594,8 @@ describe('withEntitiesRemoteScrollPagination', () => {
       });
       tick(400);
       expect(store.entities().length).toEqual(2);
+      expect(store.pagination().currentPage).toEqual(0);
+      expect(store.pagination().requestPage).toEqual(0);
     });
   }));
 
@@ -656,6 +658,79 @@ describe('withEntitiesRemoteScrollPagination', () => {
       });
       tick(400);
       expect(store.entities().length).toEqual(30);
+      expect(store.pagination().currentPage).toEqual(0);
+      expect(store.pagination().requestPage).toEqual(0);
+    });
+  }));
+
+  it('should reset cache when filter is executed and nextPage was called', fakeAsync(() => {
+    TestBed.runInInjectionContext(() => {
+      const Store = signalStore(
+        withEntities({
+          entity,
+        }),
+        withCallStatus({ initialValue: 'loading' }),
+        withEntitiesRemoteScrollPagination({
+          entity,
+          pageSize: 10,
+          pagesToCache: 3,
+        }),
+        withEntitiesRemoteFilter({
+          entity,
+          defaultFilter: { search: '', foo: 'bar' },
+        }),
+        withEntitiesLoadingCall({
+          fetchEntities: ({ entitiesFilter, entitiesPagedRequest }) => {
+            let result = [...mockProducts];
+            const total = result.length;
+            if (entitiesFilter()?.search)
+              result = mockProducts.filter((entity) =>
+                entitiesFilter()?.search
+                  ? entity.name
+                      .toLowerCase()
+                      .includes(entitiesFilter()?.search.toLowerCase())
+                  : false,
+              );
+            const options = {
+              skip: entitiesPagedRequest()?.startIndex,
+              take: entitiesPagedRequest()?.size,
+            };
+            if (options?.skip || options?.take) {
+              const skip = +(options?.skip ?? 0);
+              const take = +(options?.take ?? 0);
+              result = result.slice(skip, skip + take);
+            }
+            return of({ entities: result, total });
+            return Promise.resolve({ entities: result, total: result.length });
+          },
+        }),
+      );
+      const store = new Store();
+      TestBed.flushEffects();
+      // first fill cache
+      tick();
+      expect(store.entities().length).toEqual(30);
+      store.loadEntitiesNextPage();
+      tick();
+      tick();
+      store.loadEntitiesNextPage();
+      tick();
+      store.loadEntitiesNextPage();
+      tick();
+      expect(store.entities().length).toEqual(60);
+      expect(store.entitiesCurrentPage().pageIndex).toEqual(3);
+      expect(store.entitiesCurrentPage().entities).toEqual(
+        mockProducts.slice(30, 40),
+      );
+
+      store.filterEntities({
+        filter: { search: 'zero' },
+        patch: true,
+      });
+      tick(400);
+      expect(store.entities().length).toEqual(2);
+      expect(store.pagination().currentPage).toEqual(0);
+      expect(store.pagination().requestPage).toEqual(0);
     });
   }));
 

diff --git a/...traits/signals/src/lib/with-entities-pagination/with-entities-remote-scroll-pagination.ts b/...traits/signals/src/lib/with-entities-pagination/with-entities-remote-scroll-pagination.ts
@@ -456,6 +456,8 @@ function clearEntitiesCache(
         ...pagination(),
         total: 0,
         hasMore: true,
+        currentPage: 0,
+        requestPage: 0,
       },
     },
   );