Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow disabling clear selection on filter an sort #97

Closed
gabrielguerrero opened this issue Jun 7, 2024 · 1 comment · Fixed by #99
Closed

allow disabling clear selection on filter an sort #97

gabrielguerrero opened this issue Jun 7, 2024 · 1 comment · Fixed by #99
Labels
enhancement New feature or request released signals

Comments

@gabrielguerrero
Copy link
Owner

withEntitiesSingleSelection and withEntitiesMultiSelection, currently clear the selection if a filter or a remoter sort happens, because both cloud create an invalid selection if the previously selected entities are no longer present
There are some cases where dev might not like this behaviour, so this PR is to add two flags, cleanOnFilter and clearOnRemoteSort, to both traits. These flags default to true and, when set to false, will disable this behaviour.
@gabrielguerrero gabrielguerrero added enhancement New feature or request signals labels Jun 7, 2024
gabrielguerrero pushed a commit that referenced this issue Jun 7, 2024
feat(signals): allow disabling clear selection on filter an sort
f997f4e 
Add to withEntitiesSingleSelection and withEntitiesMultiSelection, flags cleanOnFilter and
clearOnRemoteSort to allow disabling clear  onfi filter an remotete sort

Fix #97
@gabrielguerrero gabrielguerrero mentioned this issue Jun 7, 2024
Merged
gabrielguerrero pushed a commit that referenced this issue Jun 7, 2024
feat(signals): allow disabling clear selection on filter an sort
1d061d3 
Add to withEntitiesSingleSelection and withEntitiesMultiSelection, flags cleanOnFilter and
clearOnRemoteSort to allow disabling clear  onfi filter an remotete sort

Fix #97
gabrielguerrero pushed a commit that referenced this issue Jun 7, 2024
@gabrielguerrero
feat(signals): allow disabling clear selection on filter an sort
11b4f7d 
Add to withEntitiesSingleSelection and withEntitiesMultiSelection, flags cleanOnFilter and
clearOnRemoteSort to allow disabling clear  onfi filter an remotete sort

Fix #97
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

🎉 This issue has been resolved in version 17.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released signals
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/clean on filter and bug fix gabrielguerrero/ngrx-traits
1 participant
@gabrielguerrero