Skip to content

Commit

Permalink
n-api: bump version of n-api supported
Browse files Browse the repository at this point in the history
Bump the version due to additions to the api.

PR-URL: nodejs#19497
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
mhdawson authored and Gabriel Schulhof committed Apr 12, 2018
1 parent b25dec8 commit c33daa4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/node_version.h
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,6 @@
#define NODE_MODULE_VERSION 57

// the NAPI_VERSION provided by this version of the runtime
#define NAPI_VERSION 2
#define NAPI_VERSION 3

#endif // SRC_NODE_VERSION_H_
4 changes: 2 additions & 2 deletions test/addons-napi/test_general/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ assert.notStrictEqual(test_general.testGetPrototype(baseObject),
test_general.testGetPrototype(extendedObject));

// test version management functions
// expected version is currently 1
assert.strictEqual(test_general.testGetVersion(), 2);
// expected version is currently 3
assert.strictEqual(test_general.testGetVersion(), 3);

const [ major, minor, patch, release ] = test_general.testGetNodeVersion();
assert.strictEqual(process.version.split('-')[0],
Expand Down

0 comments on commit c33daa4

Please sign in to comment.