Upgrade to urql v4 under the hood #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airhorns
force-pushed
the
urql-4
branch
3 times, most recently
from
68b6519
to
b9d3483
Compare
airhorns
force-pushed
the
urql-4
branch
2 times, most recently
from
0eba6aa
to
b639cfc
Compare
airhorns
force-pushed
the
urql-4
branch
3 times, most recently
from
e465e06
to
2607646
Compare
airhorns
commented
Jun 22, 2023
| @@ -100,7 +99,7 @@ export class GadgetConnection { | |||
| } else { | |||
| this._fetchImplementation = fetchPolyfill; | |||
| } | |||
| this.websocketImplementation = options.websocketImplementation ?? WebSocket; | |||
| this.websocketImplementation = options.websocketImplementation ?? globalThis?.WebSocket ?? WebSocket; | |||
There was a problem hiding this comment.
I also upgraded the isomorphic-ws library, which stopped monkeypatching the global. This makes our tests keep working.
airhorns
commented
Jun 22, 2023
| @@ -328,20 +328,21 @@ export class GadgetConnection { | |||
| } | |||
|
|
|||
| private newBaseClient() { | |||
| const exchanges = [dedupExchange]; | |||
There was a problem hiding this comment.
urql 4 doesnt use this exchange anymore
airhorns
commented
Jun 22, 2023
| return { | ||
| subscribe: (sink) => { | ||
| const dispose = this.baseSubscriptionClient.subscribe(operation, sink as Sink<ExecutionResult>); | ||
| const input = { ...request, query: request.query || "" }; | ||
| const dispose = this.baseSubscriptionClient.subscribe(input, sink as Sink<ExecutionResult>); |
There was a problem hiding this comment.
This type changed between versions of urql -- the query is now options for some reason, so this maps to the kind of object that graphql-ws is expecting
airhorns
commented
Jun 22, 2023
| @@ -19,9 +19,9 @@ | |||
| "prerelease": "gitpkg publish" | |||
| }, | |||
| "dependencies": { | |||
| "@gadgetinc/api-client-core": "^0.13.10", | |||
| "@gadgetinc/api-client-core": "^0.13.14", | |||
There was a problem hiding this comment.
Our react bindings now need the newest api-client-core which also depends on urql 4, as well as depending on urql 4 themselves
ngc
approved these changes
Jun 23, 2023
airhorns
force-pushed
the
urql-4
branch
3 times, most recently
from
d41a4f9
to
8be6b1f
Compare
|
ping @jasong689 💖 |
jasong689
approved these changes
Jun 26, 2023
- removes the deprecated exchanges that are built into the client now - adds the new mandatory properties to the `OperationResult` type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades us to urql v4 for all generated api client packages.
OperationResulttypeMore comments inline
Gadget side test PR here: https://github.com/gadget-inc/gadget/pull/6756 (it works!)