Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the graphql operation to the client URL #216

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

airhorns
Copy link
Contributor

@airhorns airhorns commented Jun 26, 2023

We have this Gadget side, I think it'd be really helpful API client side to see in the network tab which operation is doing what:

CleanShot 2023-06-25 at 21 32 47@2x

@airhorns airhorns marked this pull request as ready for review June 26, 2023 01:32
@airhorns airhorns requested a review from jasong689 June 26, 2023 01:33
return (ops$) =>
pipe(
ops$,
onPush((op) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was wondering what the difference between tap and onPush was and turns out they're the same.

@airhorns airhorns merged commit 661b1f9 into main Jun 26, 2023
3 checks passed
@airhorns airhorns deleted the url-param-exchange branch June 26, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants