Send dev harness event from react hook when it is a stubbed action #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanko0511
commented
Sep 11, 2024
Comment on lines
+818
to
+826
| useAction({ | ||
| // @ts-expect-error intentionally passing the wrong type | ||
| type: "stubbedAction", | ||
| reason: "MissingApiTrigger", | ||
| dataPath: "fakePath", | ||
| functionName: "fakeFunction", | ||
| modelApiIdentifier: "fakeModel", | ||
| variables: {}, | ||
| }), |
There was a problem hiding this comment.
Some parameters are unavailable today, so I need to make a fake object to trigger an event. I'll update the tests once we have shipped the change to the Gadget side.
alanko0511
force-pushed
the
alan/add-stubbed-action-event
branch
from
bf8f5bb
to
c6df1c4
Compare
alanko0511
force-pushed
the
alan/add-stubbed-action-event
branch
from
c6df1c4
to
78c3ce2
Compare
MillanWangGadget
approved these changes
Sep 13, 2024
danroberts
approved these changes
Sep 13, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sends a dev harness event when the action is a stubbed action (i.e. no API trigger)
Gadget side to consume this new event type: https://github.com/gadget-inc/gadget/pull/12894
PR Checklist