Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auto component error messages #643

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

alanko0511
Copy link
Contributor

@alanko0511 alanko0511 commented Sep 16, 2024

This PR updates the error message when an invalid model or action is passed to AutoForm or AutoTable.

PR Checklist

  • Important or complicated code is tested
  • Any user facing changes are documented in the Gadget-side changelog
  • Any immediate changes are slated for release in Gadget via a generated package dependency bump
  • Versions within this monorepo are matching and there's a valid upgrade path

@alanko0511 alanko0511 force-pushed the alan/rmn-111-better-autocomponent-error-messages branch from 0e92c4d to 0e00432 Compare September 16, 2024 19:48
@alanko0511 alanko0511 marked this pull request as ready for review September 17, 2024 16:37
@alanko0511 alanko0511 force-pushed the alan/rmn-111-better-autocomponent-error-messages branch 4 times, most recently from 7c88703 to fa6ca4a Compare September 17, 2024 20:01
export const TriggerableActionRequiredErrorMessage = `"action" must be a valid Gadget action with an API trigger to be used in AutoForms`;

export const MissingActionPropErrorMessage = "Specify a valid Gagdet action to use AutoForm";
export const InvalidActionErrorMessage = `"action" is not a valid Gadget action`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: maybe mention here that the action is used in AutoForm

@alanko0511 alanko0511 force-pushed the alan/rmn-111-better-autocomponent-error-messages branch from fa6ca4a to e270c73 Compare September 18, 2024 13:58
@alanko0511 alanko0511 force-pushed the alan/rmn-111-better-autocomponent-error-messages branch from e270c73 to 3386194 Compare September 18, 2024 14:53
@alanko0511 alanko0511 merged commit 2850612 into main Sep 19, 2024
9 checks passed
@alanko0511 alanko0511 deleted the alan/rmn-111-better-autocomponent-error-messages branch September 19, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants