Hide hasMany input on join model when using actions on models with hasManyThrough fields #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MillanWangGadget
force-pushed
the
mill/RMN-106_hideHasManyThroughJoinModelHasMany
branch
2 times, most recently
from
0537e9e
to
ef4f8a1
Compare
danroberts
reviewed
Sep 24, 2024
packages/react/src/metadata.tsx
Outdated
| @@ -355,6 +390,7 @@ export const filterAutoFormFieldList = ( | |||
| fields: FieldMetadata[] | undefined, | |||
| options?: { include?: string[]; exclude?: string[]; isUpsertAction?: boolean } | |||
| ): FieldMetadata[] => { | |||
| console.log("fields :", fields); | |||
packages/react/src/metadata.tsx
Outdated
| @@ -408,6 +447,12 @@ const specialModelKeys = new Set(["DataModel-Shopify-Shop"]); | |||
| const isAcceptedFieldType = (field: FieldMetadata) => acceptedAutoFormFieldTypes.has(field.fieldType); | |||
| const isAcceptedUpsertFieldType = (field: FieldMetadata) => field.fieldType === FieldType.Id || isAcceptedFieldType(field); | |||
|
|
|||
| const isNotJoinModelHasManyField = (field: FieldMetadata) => | |||
| field.fieldType !== FieldType.HasMany || | |||
There was a problem hiding this comment.
I think this would be more clearly expressed in the positive -- isJoinModelHasManyField because some of the double negatives confused me for a second.
(field.fieldType === FieldType.HasMany &&
field.configuration.__typename === "GadgetHasManyConfig" &&
field.configuration.isJoinModelHasManyField)
...
// Remove `hasMany` fields that emerge from `hasManyThrough` fields that are not actually model fields
subset = subset.filter(field => !isJoinModelHasManyField(field));
There was a problem hiding this comment.
Updated such that the filter works as a positive check
MillanWangGadget
force-pushed
the
mill/RMN-106_hideHasManyThroughJoinModelHasMany
branch
2 times, most recently
from
76fa62d
to
9106438
Compare
…sManyThrough fields
MillanWangGadget
force-pushed
the
mill/RMN-106_hideHasManyThroughJoinModelHasMany
branch
from
9106438
to
6b96215
Compare
danroberts
approved these changes
Sep 24, 2024
alanko0511
approved these changes
Sep 24, 2024
MillanWangGadget
deleted the
mill/RMN-106_hideHasManyThroughJoinModelHasMany
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasManyThroughinputs will come in a follow up