Prevent AutoForm validation with custom children to prevent being blocked unshown required fields #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanko0511
reviewed
Sep 30, 2024
packages/react/src/auto/AutoForm.ts
Outdated
Comment on lines
158
to
161
| const hasCustomChildren = !!props.children; | ||
| const fieldPathsToValidate = hasCustomChildren | ||
| ? [] // With custom children, do not validate fields before sending them to avoid blocking submissions due to missing required fields | ||
| : fields.map(({ path }) => path); |
There was a problem hiding this comment.
Should we use useMemo to fieldPathsToValidate with a [hasCustomChildren] as the dep array?
There was a problem hiding this comment.
Good call. Updated to add a useMemo to avoid remapping on fields
alanko0511
reviewed
Sep 30, 2024
| "@gadgetinc/react": patch | ||
| --- | ||
|
|
||
| - Added an error message to AutoForm when passing in `include/exclude` options alongside child components |
There was a problem hiding this comment.
We're throwing a hard error, so maybe it should be "Throw an error" instead.
There was a problem hiding this comment.
Updated to say that a new error is thrown
alanko0511
approved these changes
Sep 30, 2024
…cked unshown required fields
MillanWangGadget
force-pushed
the
mill/preventAutoFormValidationsWithCustomChildren
branch
from
6a0b89a
to
d528d86
Compare
danroberts
approved these changes
Oct 1, 2024
MillanWangGadget
deleted the
mill/preventAutoFormValidationsWithCustomChildren
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include/excludeAutoForm propertiesAutoFormwill now avoid all local validations so that the requests are always sent to the server to be validated there.