Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process groups #82

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Process groups #82

merged 1 commit into from
Jun 9, 2023

Commits on Jun 9, 2023

  1. Kill the whole process group when shutting down, instead of just the …

    …one child process
    
    This fixes a bug where when wds is orchestrating a process that starts
    its own child processes, those child processes can be come zombies if we
    just SIGTERM/SIGKILL the main orchestrated process. What we need to do
    is kill the whole process group, which you can do by sending the
    negative pid of the parent to the kernel.
    
    See https://azimi.me/2014/12/31/kill-child_process-node-js.html
    airhorns committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    84e449a View commit details
    Browse the repository at this point in the history