Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when wrapping a render method, overwrite toString as well #25

Closed
wants to merge 1 commit into from

Conversation

capaj
Copy link

@capaj capaj commented Aug 4, 2015

I like to use toString to get a string which I match and then I can observe my stores. Without this change, I cannot run my regex against the wrapped function toString. See capaj/react-observe-store#1 for a better explanation

I like to use toString to get a string which I match and then I can observe my stores. Without this change, I cannot run my regex against the wrapped function toString. See  capaj/react-observe-store#1
@gaearon
Copy link
Owner

gaearon commented Aug 27, 2015

Sorry for long time no show.
Um, I'm torn on this one. It kinda feels invasive. But then, maybe not!

Let me do this in React Proxy instead, it's alpha anyway. And you can use it from React Hot Loader 2 alpha.

@gaearon gaearon closed this Aug 27, 2015
@gaearon
Copy link
Owner

gaearon commented Aug 27, 2015

This is done in React Proxy 0.6.7.
To try it, install react-hot-loader@2.0.0-alpha-3 (discussion).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants