-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hot
could not find the id
property in the module
you have provided
#1228
Comments
Try |
^ that import { hot } from 'react-hot-loader';
export default hot(module)(App);
import { hot } from 'react-hot-loader/root';
export default hot(App); |
I am getting the same error. |
So, what is your system? Try really use the first version of |
Tried with: When using the example above, still getting: |
|
Not using parcel. |
You are doing your best to keep |
Real nice. I'm caught in the same conundrum here. Using 'react-hot-loader/root' gives me an error telling me to stop using that import path. Using the other import path gives me the same exception as OP. Why is this closed? I don't see any resolution in the issue. |
Because nobody provided any example to reproduce. Every time (like here - #1240) I am asking for it, but nobody ever provided it or tried to spend their time to debug the issue. What you shall understand - there is a standard module API. It says
If In any case - the problem is with your code, and there is nothing I could fix from side of mine one. I am happy to help, once you provide example to play with. If something is wrong with And yet again - "you" are the only one who have the issue and able to debug and mitigate it. |
Just discovered this library and Parcel about an hour ago. Trying to be as polite as possible, "figure it out" is NOT a solution to get people on board with your product. I too am having the same issue as others in this thread. Each set of documentation says "refer to the other docs" and we're just suppose to figure it out. So much for Parcel's "zero configuration" and "Get started instantly" sales-pitch. I'd much rather go back to React because at least it works out of the box. FWIW: I've tried every variation of the snippets mentioned in this thread and elsewhere and even though I can get it to run with no errors, I'm left with a blank page. |
@bugs181 - I really need some help here. There is a parcel example here, and it just works. From this image it's clearly visible why Trying to be as polite as possible, but I've invested some time trying to solve this issue and only asking you to do the same. |
As I said - there is nothing React-Hot-Loader could do with the According to the issue both webpack(@Nitzperetz "Not using parcel.") and parcel(@bugs181 using Parcel) bundlers are affected, but the real reason is unknown. Long story short:
The expectations from module system were explained here - #1228 (comment) Local tests, examples and other users are not facing this issue, thus I am closing this one, as long as nobody provided an example and I am not able to confirm the issue. |
v4.8.5 might fix it, or provide a more understandable error. |
secretcowlevel/scl-react-starter@82c6aff There is a commit that seems simple enough to me, based on the documentation I see here and on webpack's site and I get the error that the new API is not compatible. Maybe now you'll have the info you need to offer a solution? I was just trying to understand the current state of react-hot-loading and it seems like I'm not the only one ending up at a deadend based on documentation. I'm sure it's just user error, though. Can you help fill in the gap?
EDIT: This is the error I want to understand. Following the directions leads me to the bug listed here. And also the documentation is very clear that we should NOT be using the old API. So I want to understand the new one. I have latest webpack/react/etc as far as I can tell, so I'm having trouble figuring out why. |
Update I was able to get it working thanks to this thread #911 This is just a "too many cooks in the kitchen" problem. My problem was I was enabled HotModuleReplacementPlugin() based on one doc AND |
I had similar errors to those mentioned here, but with webpack. In my case the source was missing this key step from the readme:
Switched the order of the imports and it started working. |
Thanks @framerate. I had the same issue. ie. used |
Uncaught Error: React-hot-loader:
hot
could not find theid
property in themodule
you have providedExpected behavior
The getting started guide works as expected
Actual behavior
What actually happens: above mentioned error is thrown
Environment
React Hot Loader version: 4.8.2
Run these commands in the project folder and fill in their results:
node -v
: v8.9.4npm -v
: 5.6.0Then, specify:
Error is thrown from:
which is taken from Getting started guide
The text was updated successfully, but these errors were encountered: