Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call toString on action type before displaying #29

Merged
merged 1 commit into from
Apr 3, 2016
Merged

Call toString on action type before displaying #29

merged 1 commit into from
Apr 3, 2016

Conversation

anibali
Copy link
Contributor

@anibali anibali commented Jan 17, 2016

I like to use Symbols as action types in Redux, but currently these will not show up in the log monitor. This PR contains the most straightforward way of solving this, which is to call toString on the action type.

@anibali
Copy link
Contributor Author

anibali commented Jan 17, 2016

Ah couldn't tell from the title that there was another PR relating to this problem (#15). Will close this.

@anibali anibali closed this Jan 17, 2016
@ozanmakes
Copy link

I think this is still a useful addition even if #15 doesn't get merged in. @gaearon would you consider applying this change?

@gaearon
Copy link
Owner

gaearon commented Apr 3, 2016

This should be fixed in react-json-tree and I bumped its version so should work now.

@gaearon
Copy link
Owner

gaearon commented Apr 3, 2016

Ah wait, I see, this is a little different. Yeah I’ll take it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants