Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn but not throw when the monitor is rendered without being included in the store configuration #36

Merged
merged 1 commit into from
Apr 2, 2016

Conversation

zalmoxisus
Copy link
Collaborator

@gaearon
Copy link
Owner

gaearon commented Mar 1, 2016

Can you help me understand why this is needed? We can add more state to the future so it’s not just about initial scroll top.

@zalmoxisus
Copy link
Collaborator Author

It will not affect the regular usage, but will allow to render the monitor without having DevTools's instrumentation enhancer added to the store. It is just a convenience for switching from using vanilla DevTools to the extension and back by changing only the store enhancer to

window.devToolsExtension ? window.devToolsExtension() : DevTools.instrument()

Of course, instead of implementing this hacky change better to also add as we recommend

{ !window.devToolsExtension ? <DevTools /> : null }

but usually users forget about the rendering part and it's not obvious what is the problem when getting the error as in zalmoxisus/redux-devtools-extension#57.

@gaearon gaearon merged commit 486381a into gaearon:master Apr 2, 2016
@gaearon
Copy link
Owner

gaearon commented Apr 2, 2016

I don’t fully understand it but I’ll take it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants