Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace JSONTree.expandRoot with shouldExpandNode #51

Merged
merged 2 commits into from
Apr 17, 2016
Merged

replace JSONTree.expandRoot with shouldExpandNode #51

merged 2 commits into from
Apr 17, 2016

Conversation

tomatau
Copy link
Contributor

@tomatau tomatau commented Apr 16, 2016

react-json-tree has introduced a deprecation error https://github.com/alexkuz/react-json-tree/blob/cef50107ef66e4763c8c5abedac063d2efae303c/src/index.js#L62-L64

This PR uses the new recommended prop of shouldExpandNode

@zalmoxisus
Copy link
Collaborator

I'd suggest not to use arrow functions in JSX props, here's why. We can just move them outside an use shouldExpandNode={this.shouldExpandNode}.

@tomatau
Copy link
Contributor Author

tomatau commented Apr 16, 2016

done

@tomatau tomatau force-pushed the should-expand-node branch from 3df4c39 to 9095b35 Compare April 16, 2016 11:17
@gaearon gaearon merged commit 82f7815 into gaearon:master Apr 17, 2016
@gaearon
Copy link
Owner

gaearon commented Apr 17, 2016

Thank you! Out in 1.0.11.

@tomatau tomatau deleted the should-expand-node branch April 17, 2016 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomatau @zalmoxisus @gaearon