Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin GitVersion to v5 in pipeline and update templates #479

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

johlju
Copy link
Collaborator

@johlju johlju commented Jul 24, 2024

Pull Request

Pull Request (PR) description

Fixed

  • Pinned GitVersion to v5 in the pipeline since v6 is not yet supported, also
    updated templates to pin GitVersion v5. Workaround for issue #477.

Task list

  • The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
  • Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
  • Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link
Collaborator Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit 15f57f5 into gaelcolas:main Jul 24, 2024
12 checks passed
@johlju johlju deleted the fix/pin-gitversion-v5 branch July 24, 2024 08:17
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81%. Comparing base (77d44e1) to head (0ecf19c).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #479   +/-   ##
===================================
  Coverage    81%    81%           
===================================
  Files        44     44           
  Lines      2328   2328           
===================================
  Hits       1904   1904           
  Misses      424    424           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant