-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create FQCN with module namespace #16
feat: create FQCN with module namespace #16
Conversation
Thanks for the PR @alpaca0984! |
I wish you a wonderful Christmas time, gaelmarhic 🎄 |
Thanks a lot @alpaca0984! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for this PR and sorry for the delay!
@alpaca0984 I have tested the PR as well as generated and published a new version. |
Hi @gaelmarhic , I hope you had a great vacation :) |
Hi @alpaca0984 , |
Overview
Quadrant supports partially qualified class names by extracting package names from AndroidManifest.xml (ref: #3).
However, the package attribute was deprecated in the Android Gradle Plugin (AGP) 7.3.0. Also, in the AGP 8.0.0, the
namespace
becomes a required parameter.This PR aims to keep supporting partially qualified class names by retrieving
namespace
property from an Android extension.If you want to check how these changes behave in an app, I recommend using my sample project https://github.com/alpaca0984/QuadrantKspCompileSample. It uses AGP 8.0.0 and imports this Quadrant plugin.
References