Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create FQCN with module namespace #16

Merged
merged 3 commits into from
Jan 27, 2024

Conversation

MasaHirano
Copy link
Contributor

Overview

Quadrant supports partially qualified class names by extracting package names from AndroidManifest.xml (ref: #3).
However, the package attribute was deprecated in the Android Gradle Plugin (AGP) 7.3.0. Also, in the AGP 8.0.0, the namespace becomes a required parameter.

This PR aims to keep supporting partially qualified class names by retrieving namespace property from an Android extension.

If you want to check how these changes behave in an app, I recommend using my sample project https://github.com/alpaca0984/QuadrantKspCompileSample. It uses AGP 8.0.0 and imports this Quadrant plugin.

References

@gaelmarhic
Copy link
Owner

Thanks for the PR @alpaca0984!
I will try to review it ASAP (now sure when though, because of the holidays).

@MasaHirano
Copy link
Contributor Author

I wish you a wonderful Christmas time, gaelmarhic 🎄

@gaelmarhic
Copy link
Owner

Thanks a lot @alpaca0984!
I wish you a wonderful Christmas too :)

Copy link
Owner

@gaelmarhic gaelmarhic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for this PR and sorry for the delay!

@gaelmarhic gaelmarhic merged commit 701c010 into gaelmarhic:master Jan 27, 2024
@gaelmarhic
Copy link
Owner

@alpaca0984 I have tested the PR as well as generated and published a new version.
Here goes:
https://github.com/gaelmarhic/Quadrant/releases/tag/v1.9
https://plugins.gradle.org/plugin/com.gaelmarhic.quadrant/1.9
Thanks again for your contributions! :)

@MasaHirano
Copy link
Contributor Author

Hi @gaelmarhic , I hope you had a great vacation :)
Thank you for the publication. I added it to my project and... found an issue. Now, the extension configuration doesn't work.
I know what is going wrong. Will open a follow-up PR soon

@MasaHirano MasaHirano deleted the feat-support-namespace branch January 30, 2024 17:56
@gaelmarhic
Copy link
Owner

Hi @alpaca0984 ,
I had a great holidays, thanks. :)
Great catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants