add scala 3 support #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endertunc
commented
Sep 16, 2022
|
|
||
| scalaVersion := scala213Version | ||
| scalaVersion := scala3Version |
There was a problem hiding this comment.
Updated default version to scala3 but this might not be desirable given that editor supports are still trying to catch up. Happy to set it back to 2.13.
endertunc
commented
Sep 16, 2022
| val ZioCatsVersion = "3.3.0" | ||
| val DoobieVersion = "1.0.0-RC2" | ||
| val AnormVersion = "2.6.10" | ||
| val H2Version = "1.4.200" | ||
| val AnormVersion = "2.7.0" |
There was a problem hiding this comment.
Scala3 support recently added to anorm!
playframework/anorm#474
https://github.com/playframework/anorm/releases/tag/2.7.0
endertunc
commented
Sep 16, 2022
|
|
||
| /** Converts a Doobie stream to a ZStream. Note that you can provide a queue size, default value is the same as in ZIO. */ | ||
| final def tzioStream[A](q: => fs2.Stream[Query, A], queueSize: => Int = DefaultStreamQueueSize)(implicit trace: Trace): TranzactIOStream[A] = | ||
| ZStream.serviceWithStream[Connection] { c => | ||
| c.transP.apply(q).toZStream(queueSize) | ||
| }.mapError(DbException.Wrapped) | ||
| }.mapError(DbException.Wrapped.apply) |
There was a problem hiding this comment.
There were warnings from compiler suggesting me to explicitly call apply methods so I did.
endertunc
commented
Sep 16, 2022
build.sbt
Outdated
|
|
||
| val scala2allVersionsOption = Seq( |
There was a problem hiding this comment.
Not all options in allVersionsOption were applicable in scala3 so I extracted the ones that's not applicable in scala3 to scala2allVersionsOption
gaelrenoux
approved these changes
Sep 25, 2022
|
Looks good to me! Made a small fix and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #33
Let me know if you have any feedback. Happy to address them.
BTW, thanks for the library!