-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sonarcloud coverage #10
Conversation
See gaepdit/EPD-IT#82 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you were having trouble getting coverlet to work. I'm pretty sure it was just a typo (see code comment below).
When I use the dotnet-coverage command you currently have, I get a lot of extraneous results (see screenshot), plus error messages when using report generator.
You could probably get it to work with some additional tweaking, but it's probably easier to go back to coverlet.
It looks like your latest commit is working. I tried getting coverlet to work as well and got the same result as you: The command works fine when run locally but returns no results on GitHub. But since you got this other method to work, it's not worth pursuing. One question though. Is the trx logger option still needed or was that just for testing? If it's not needed, please remove, and I'll merge this on Monday. Thanks for your great work on this! |
Kudos, SonarCloud Quality Gate passed! |
the result-directory option used to require the logger option to work (https://stackoverflow.com/questions/49390416/dotnet-test-not-creating-test-results-folder). I have tested it locally, and it is not needed anymore. |
Ok, thanks. I was wondering if it was something like that. |
No description provided.