add checks for NSR to overlap a split read #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand the devel release failures |
added 2 commits
June 22, 2022 10:32
nickhsmith
commented
Jun 22, 2022
| @@ -17,7 +17,7 @@ installIfReq <- function(p, Ncpus=NCPUS, ...){ | |||
| # install Bioconductor | |||
| if(!requireNamespace("BiocManager", quietly=TRUE)) | |||
| install.packages("BiocManager", Ncpus=NCPUS) | |||
| BiocManager::install("BiocVersion", version=BIOC_VERSION) | |||
| BiocManager::install("BiocVersion", version=BIOC_VERSION,ask = FALSE) | |||
There was a problem hiding this comment.
important for the devel BIOC version
This reverts commit c1ac059.
c-mertes
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
thanks for the push @nickhsmith this looks good. I will merge it and push it to a new version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure for a valid FDS object that the non-spliced reads overlap with at least 1 spliced read donor or acceptor.
Enforce this during the external splice count merging