Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update recommended config to @babel/eslint-parser #479

Closed
wants to merge 2 commits into from

Conversation

Brianzchen
Copy link
Contributor

Closes #474

Recommended config now uses @babel/eslint-parser. This should be a breaking change for consumers, the only difference should be that eslint how uses a projects babel config to read files which may cause issues if the babel config has exclusions setup based on environment variables that don't play nice with eslint.

This should be a major version bump.

@wilt-rally @gajus

@Brianzchen
Copy link
Contributor Author

@gajus thoughts on this?

@gajus
Copy link
Owner

gajus commented Jun 23, 2021

  • What's the reason babel-eslint is kept as a dependency?
  • What's the reason @babel/eslint-parser is not a dependency?

@Brianzchen
Copy link
Contributor Author

  • What's the reason babel-eslint is kept as a dependency?

babel-eslint is a dev-dependency of this project is because the eslint rules of this project don't use itself, the dependency here also isn't what is shipped as a requirement to the user.

  • What's the reason @babel/eslint-parser is not a dependency?

This project doesn't use @babel/eslint-parser again because of the eslint rules it extends from are not itself. The current version of canonical eslint still uses babel-eslint https://github.com/gajus/eslint-config-canonical/blob/v20.1.0/configurations/eslintrc.json#L7. We can upgrade this as part of a separate PR because updating the dev dependencies here is not really the goal of this PR


Overall what i'm trying to do here is just update what is used by the consumer so that they get @babel/eslint-parser out of the box without needing to override babel-eslint not what this project (eslint-plugin-flowtype) internally uses.

@Brianzchen Brianzchen closed this Dec 11, 2021
Repository owner deleted a comment from Brianzchen Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'babel-eslint' deprecation and rename
2 participants