Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

feat(providers): add a subset of admin namespace #1880

Merged
merged 54 commits into from
Nov 30, 2022
Merged

feat(providers): add a subset of admin namespace #1880

merged 54 commits into from
Nov 30, 2022

Commits on Nov 28, 2022

  1. tell Geth to expose the admin namespace

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    0c0a99c View commit details
    Browse the repository at this point in the history

  2. wip: add admin namespace support 

     * add networking and peer related structs
    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    a350324 View commit details
    Browse the repository at this point in the history

  3. add rest of chain config fields

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    0fce96c View commit details
    Browse the repository at this point in the history

  4. add datadir to geth

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    4adffd4 View commit details
    Browse the repository at this point in the history

  5. fix data dir ref

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    0562f0b View commit details
    Browse the repository at this point in the history

  6. add dev flag to geth

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    26c0d66 View commit details
    Browse the repository at this point in the history

  7. set dev only if block_time is not set

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    2bedcd2 View commit details
    Browse the repository at this point in the history

  8. put mutually exclusive options in an enum

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    6a237b3 View commit details
    Browse the repository at this point in the history

  9. make block_time use the devmode enum

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    d6b9687 View commit details
    Browse the repository at this point in the history

  10. add p2p port to geth

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    fce6c40 View commit details
    Browse the repository at this point in the history

  11. add basic impls for admin endpoints

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    52a7a35 View commit details
    Browse the repository at this point in the history

  12. move from_int_or_hex to ethers-core utils

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    e28d1a1 View commit details
    Browse the repository at this point in the history

  13. fix nodeinfo protocol field 

     * the type is better represented by a struct which can have either eth
   or snap
    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    4cfaffb View commit details
    Browse the repository at this point in the history

  14. add chain id and discovery toggle for Geth

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    1033b13 View commit details
    Browse the repository at this point in the history

  15. remove PeerEvent 

     * should re-add when peer event endpoints are implemented
    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    5e3eb65 View commit details
    Browse the repository at this point in the history

  16. simplify serde options for admin responses

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    2bb8b32 View commit details
    Browse the repository at this point in the history

  17. change signature for peer modification apis 

     * these admin apis accept an enode, which _may_ be an enr, but could
   also be a legacy enode "v4" url.
    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    3dcacb4 View commit details
    Browse the repository at this point in the history

  18. add note on where ChainConfig fields come from

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    280a3d3 View commit details
    Browse the repository at this point in the history

  19. add note on PeerInfo about the source of fields

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    0c1cf6d View commit details
    Browse the repository at this point in the history

  20. add admin namespace support to CHANGELOG

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    23fa941 View commit details
    Browse the repository at this point in the history

  21. update pr number in changelog

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    09c4509 View commit details
    Browse the repository at this point in the history

  22. cargo fmt

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    f9a324a View commit details
    Browse the repository at this point in the history

  23. move chainconfig to genesis in utils

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    285f037 View commit details
    Browse the repository at this point in the history

  24. accept genesis file in geth

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    20446a3 View commit details
    Browse the repository at this point in the history

  25. add genesis writing to geth spawn

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    0052e72 View commit details
    Browse the repository at this point in the history

  26. finally get geth nodes to connect

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    343fd89 View commit details
    Browse the repository at this point in the history

  27. import io::Read in provider tests

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    02db1b1 View commit details
    Browse the repository at this point in the history

  28. fix PeerInfo and use enode id for provider test

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    6f5b06f View commit details
    Browse the repository at this point in the history

  29. make clippy happy

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    037fbcf View commit details
    Browse the repository at this point in the history

  30. improve documentation for genesis module

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    567cf38 View commit details
    Browse the repository at this point in the history

  31. remove not(wasm) attributes on genesis module

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    6183c87 View commit details
    Browse the repository at this point in the history

  32. remove debugging printlns

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    d27d0bc View commit details
    Browse the repository at this point in the history

  33. remove io::Read from provider tests

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    a345fa3 View commit details
    Browse the repository at this point in the history

  34. add failing post merge test case

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    2c3375d View commit details
    Browse the repository at this point in the history

  35. add full mainnet nodeinfo for testing

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    7efbd36 View commit details
    Browse the repository at this point in the history

  36. support deserializing json bignums to U256 

     * the serde_json arbitrary_precision feature is necessary so the
   serde_json::Number variant of `IntOrHexOrBigNum` can be converted
   into a string and fed into U256::from_dec_string
    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    51b4638 View commit details
    Browse the repository at this point in the history

  37. fix from_int_or_hex_opt doc string

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    302cb9c View commit details
    Browse the repository at this point in the history

  38. remove third variant from IntOrHex 

     * unnecessary since serde_json::Number handles smaller ints as well
    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    54ad70c View commit details
    Browse the repository at this point in the history

  39. add comments for ids

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    ae22226 View commit details
    Browse the repository at this point in the history

  40. fix enode id type in admin_peers provider test

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    cce36a6 View commit details
    Browse the repository at this point in the history

  41. fix admin typo in Cargo.toml 

    Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
    @Rjected @gakonst
    Rjected and gakonst committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    20557f0 View commit details
    Browse the repository at this point in the history

  42. add method to wait on a gethinstance adding a peer

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    7697f69 View commit details
    Browse the repository at this point in the history

  43. fix dial loop and wait_to_add_peer doc comments

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    e92dbf6 View commit details
    Browse the repository at this point in the history

  44. update geth 

     * the build can be updated by changing the GETH_BUILD env var
    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    50ccfce View commit details
    Browse the repository at this point in the history

  45. wait for geth to exit on drop

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    af47a31 View commit details
    Browse the repository at this point in the history

  46. remove unnecessary wait

    @Rjected
    Rjected committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    f6188d3 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. fix mid-handshake PeerInfo deserialization

    @Rjected
    Rjected committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    548b360 View commit details
    Browse the repository at this point in the history

  2. remove println

    @Rjected
    Rjected committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    dbb53a9 View commit details
    Browse the repository at this point in the history

  3. make tests less flaky

    @Rjected
    Rjected committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    96c897c View commit details
    Browse the repository at this point in the history

  4. handle discovery with the rest of the non dev opts

    @Rjected
    Rjected committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    7c445e3 View commit details
    Browse the repository at this point in the history

  5. dump geth stderr to debug failing ci test 

     * add method which dumps the unread stderr of the geth instance into a
   string
    @Rjected
    Rjected committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    a66548d View commit details
    Browse the repository at this point in the history

  6. remove call_raw debug println 

     * bug is due to authrpc endpoint being in use
    @Rjected
    Rjected committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    b71c71c View commit details
    Browse the repository at this point in the history

  7. use unused port when authrpc port is not specified

    @Rjected
    Rjected committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    9d7e23e View commit details
    Browse the repository at this point in the history

  8. remove dump_stderr from GethInstance 

     * did not work properly anyways
    @Rjected
    Rjected committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    8ca864c View commit details
    Browse the repository at this point in the history