Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

feat(eip712): add raw_salt attribute #2331

Merged
merged 16 commits into from
Apr 12, 2023

Conversation

DaniPopes
Copy link
Collaborator

@DaniPopes DaniPopes commented Apr 6, 2023

Motivation

Fixes #2321

Based on #2279

Solution

  • feat(eip712): add raw_salt attribute (9e92326)

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@DaniPopes DaniPopes marked this pull request as draft April 6, 2023 13:17
@DaniPopes DaniPopes marked this pull request as ready for review April 10, 2023 17:49
@DaniPopes
Copy link
Collaborator Author

Ready for review after #2279

Copy link
Collaborator

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs rebase and conflict resolved

@gakonst gakonst merged commit 9a5b31a into gakonst:master Apr 12, 2023
@DaniPopes DaniPopes deleted the feat/eip712-raw-salt branch April 12, 2023 21:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EIP712 salt is always keccak256 hashed
3 participants