Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix: correctly handle Trezor One support #2350

Merged
merged 1 commit into from
Apr 24, 2023
Merged

fix: correctly handle Trezor One support #2350

merged 1 commit into from
Apr 24, 2023

Conversation

prusnak
Copy link
Contributor

@prusnak prusnak commented Apr 14, 2023

  • Trezor version check works correctly only for Trezor Model T which uses version numbers 2.x.x
  • this PR changes the logic so also Trezor One versions are properly handled

This was referenced Apr 14, 2023
Closed
Closed
DaniPopes
DaniPopes approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, idiomatic nit

ethers-signers/src/trezor/app.rs Outdated Show resolved Hide resolved
ethers-signers/src/trezor/app.rs Outdated Show resolved Hide resolved
@prestwich prestwich merged commit 7ba514f into gakonst:master Apr 24, 2023
@prusnak prusnak deleted the trezor-one-version-check branch April 24, 2023 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@prestwich prestwich prestwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prusnak @prestwich @DaniPopes