This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix: ethers_providers::is_local_endpoint with rust matching pattern on URL::parse #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Apr 14, 2023
You want one more unit test? I thought doctest were enough? |
DaniPopes
reviewed
Apr 14, 2023
ethers-providers/src/rpc/provider.rs
Outdated
| if let Some(host) = url.host() { | ||
| match host { | ||
| Host::Domain("localhost") => return true, | ||
| Host::Ipv4(ipv4) => return ipv4 == Ipv4Addr::LOCALHOST || ipv4.is_link_local(), |
There was a problem hiding this comment.
What about ipv4.is_private() and ipv4.is_loopback()?
There was a problem hiding this comment.
Added with enabling also loopback and private addresses
ethers-providers/src/rpc/provider.rs
Outdated
Comment on lines
1459
to
1460
| // skipping IPV6 check | ||
| _ => return false, |
There was a problem hiding this comment.
Any reason not to include the same for Ipv6Addr? (ipv6.is_loopback())
There was a problem hiding this comment.
good point loopback is available for both variants
There was a problem hiding this comment.
Added with supporting also ipv6
|
@mattsse @DaniPopes all good? |
DaniPopes
approved these changes
Apr 20, 2023
prestwich
approved these changes
Apr 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2346 and foundry issue #4658
Motivation
ethers_providers::is_local_endpointfunction would only work withlocalhostand127.0.0.1strings.Solution
From substring matching to rust pattern matching based on
URL::parseresult.PR Checklist