This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat(solc): set default EVM version to Shanghai #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
May 10, 2023
There was a problem hiding this comment.
reasonable.
we also have a new model setting
settings.modelChecker.showProvedSafe
and some AST changes
https://github.com/ethereum/solidity/releases/tag/v0.8.20
perhaps we should wait until svm added 0.8.20
|
CI partly blocked by SVM 0.8.20 support |
DaniPopes
commented
May 10, 2023
| @@ -41,9 +41,7 @@ fn can_get_versioned_linkrefs() { | |||
| .unwrap(); | |||
|
|
|||
| let project = Project::builder().paths(paths).ephemeral().no_artifacts().build().unwrap(); | |||
|
|
|||
| let compiled = project.compile().unwrap(); | |||
| assert!(!compiled.has_compiler_errors()); | |||
There was a problem hiding this comment.
(I Can't comment on the file)
assert!(!compiled.has_compiler_errors());
->
compiled.assert_success();
for better message (prints self when panicking)
3 tasks
mattsse
approved these changes
May 18, 2023
|
Yeah will open separately |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://blog.soliditylang.org/2023/05/10/solidity-0.8.20-release-announcement/
Solution
PR Checklist