This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
ethers::utils::format_ether should show decimal places #2435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Well, I've just spent 30 minutes trying to understand why I see 0 ETH as the output of my code. Turns out, it was a problem in prase_ether function. Noticed an issue #2356
Solution
Use
parse_units(value, "ether").unwrap();
We can safely unwrap here, since
parse_units
returns Err only when units >= 77.PR Checklist