This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I found a problem that the network does not include transactions that filled the gas cost related fields using the Mumbai gas station oracle.
The
estimate_eip1559_fees()
impl of the initial implementation output(1 gwei, 1 gwei)
. The value given by the gas station was actually(1.48666678666667gwei, 1.48666663666668gwei)
.The proposed modification allows Oracle to simply convert the value given from the source to wei, raise the decimal point, and express it as a U256.
Frankly, I was not smart enough to fully understand how the
u256_from_f64_saturating()
function operates. However, I believe there is a definite issue with how the existing oracle function works, and the modified code has worked as intended.Solution
PR Checklist