Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix: gas oracle from_gwei_f64() #2526

Closed
wants to merge 1 commit into from
Closed

Conversation

alstjd0921
Copy link

Motivation

I found a problem that the network does not include transactions that filled the gas cost related fields using the Mumbai gas station oracle.
The estimate_eip1559_fees() impl of the initial implementation output (1 gwei, 1 gwei). The value given by the gas station was actually (1.48666678666667gwei, 1.48666663666668gwei).
The proposed modification allows Oracle to simply convert the value given from the source to wei, raise the decimal point, and express it as a U256.

Frankly, I was not smart enough to fully understand how the u256_from_f64_saturating() function operates. However, I believe there is a definite issue with how the existing oracle function works, and the modified code has worked as intended.

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@alstjd0921 alstjd0921 closed this Aug 2, 2023
@0xfourzerofour
Copy link
Contributor

I am getting the same issue, did you figure out what was going on @alstjd0921

@alstjd0921
Copy link
Author

I am getting the same issue, did you figure out what was going on @alstjd0921

change works well but I closed the pr because there was no review for a long time. I'll reopen it if necessary.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants