Don't overwrite remappings if provided by Settings #2530
Conversation
| if self.settings.remappings.is_empty() { | ||
| self.settings.remappings = remappings; | ||
| } else { | ||
| warn!("remappings in settings conflicts with path configurations"); | ||
| } |
There was a problem hiding this comment.
I disagree here,
I'd expect that a function called with_remappings would always set the remappings
There was a problem hiding this comment.
That's the point where I'm open to discussion. Note as the code says, for yul it won't set remapping so I did it this way. So your expectation is already wrong.
Another way is to modify here:
ethers-rs/ethers-solc/src/compile/project.rs
Line 546 in 594627d
Settings there. Are you fine with that?
|
@wtdcode The assumption is that the function always sets the remappings. Yul doesn't have remappings (I think?), and in practice it's almost always false. What would this fix? |
ethers-rs/ethers-solc/src/compile/project.rs Line 543 in 28bb3c0 When compiling a project, it simply overwrites all existing remappings (in many cases, empty remappings), which overwrites the remappings inherited from the settings. |
Motivation
remappings should not be simply overwritten if there are any, which is especially the case when downloading standard json from etherscan.
PR Checklist