Re-enable the transaction.other field for optimism feature

[mdehoog]

Motivation

I'm in the process of adding op-stack deposit tx support to anvil. This requires enabling the optimism feature.

Anvil uses the other field to pass back additional information: https://github.com/foundry-rs/foundry/blob/49007938138ae26379e7a19bf3b2ec2ba6822017/crates/anvil/src/eth/api.rs#L1801-L1812

Solution

Remove the optimism feature opt-out from the other field. This also makes it consistent with the Block struct:

ethers-rs/ethers-core/src/types/block.rs

Lines 109 to 112 in 70e5f02

	/// Captures unknown fields such as additional fields used by L2s
	#[cfg(not(feature = "celo"))]
	#[serde(flatten)]
	pub other: crate::types::OtherFields,

and the TransactionReceipt struct:

ethers-rs/ethers-core/src/types/transaction/response.rs

Lines 531 to 534 in 70e5f02

	/// Captures unknown fields such as additional fields used by L2s
	#[cfg(not(feature = "celo"))]
	#[serde(flatten)]
	pub other: crate::types::OtherFields,

PR Checklist

• Added Tests
• Added Documentation
• Breaking changes

[mattsse]

why is opting out required here required for optimism?

[mdehoog]

My understanding is that Anvil uses the other field to pass back additional information: https://github.com/foundry-rs/foundry/blob/49007938138ae26379e7a19bf3b2ec2ba6822017/crates/anvil/src/eth/api.rs#L1801-L1812

If we enable the optimism feature for the Anvil build, we lose this field.

[mdehoog]

for example, in my anvil branch that adds op deposit tx support, i've had to disable usage of the other field: foundry-rs/foundry@master...mdehoog:foundry:op-deposit#diff-a76a82dc700c0415fcd07ec10cde2ad56234e41af0ea3c07f8d1a8383b8b0913L1803-R1812

[mattsse]

okay, I think this is reasonable to always enable this because this is also useful for other chains that include additional fields

[mattsse]

I'm holding off on merging until we have a foundry companion PR

[mattsse]

as discussed, this is reasonable to capture anything else, regardless of the optimism feature,
does not impact foundry but makes it possible to capture OP fields