This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Fix handling of json rpc errors that use "details" instead of "message" #2707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I ran into an issue when using the
RetryClient
with a Polygon Mumbia RPC endpoint (https://rpc-mumbai.maticvigil.com/
). The error it returns looks like this:{"error":{"details":"Bad parameters in JSONRPC request: eth_getLogs.","code":-32005},"jsonrpc":"2.0","id":19}
Without this change the JsonRpcError fails to deserialize and the retry logic that is dependent on the JSON error code does not run.
Solution
Make the deserialization a bit more flexible, and have it support both
"message"
and"details"
.PR Checklist
Thank you!