This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
refactor: pending txns don't wait to poll futures until interval elapses #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
approved these changes
Jul 10, 2020
There was a problem hiding this comment.
LGTM, good catch - let's keep in mind that there might be some room for improvement in the hand-written futures by using ctx.waker().wake_by_ref() similarly to how it's done herehttps://github.com/gakonst/ethers-rs/blob/master/ethers-providers/src/stream.rs#L116-L120
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The pending tx object always polled interval using
ready!before checking the result of any pending API requests. This means that in addition to the rate-limiting behavior, API results would be ignored until the interval elapsedSolution
Add intermediate
Pausedstates. These states wait for the interval to elapse, and then kick off a new API request. I left in the immediate non-rate limited transition in checking receipt, as that can trigger at most once.