Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: extract some methods of the 2D renderers from the Engine #2391
Refactor: extract some methods of the 2D renderers from the Engine #2391
Changes from all commits
3ff8a7b
4afe44b
603ba2a
0ae6484
1a89b5d
a5f1ab9
7ad02b4
e97c4aa
2f2615b
47c9c7e
e52b60a
8a48797
a311f2d
9a06859
f6f373b
f6b35a9
47d670a
8c0fc37
e71b5d6
5df85bc
0a09fee
82f7f82
12d40f3
028e4b0
2b92fe1
168dcee
73c2cb7
ec4a457
d4e0d5d
432b75c
b55549d
e6ea057
fc39d5d
214b8e6
ee29a4f
ca9450d
1422f7d
63c7b12
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 12 in packages/core/src/2d/text/TextRenderer.ts
GitHub Actions / lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Use TypeScript access modifiers instead of underscore prefixes
The method
_createTextMaterial
uses an underscore prefix to indicate it's intended for internal use. In TypeScript, it's recommended to use theprivate
orprotected
access modifiers to enforce encapsulation rather than relying on naming conventions.Apply this diff to make the method
private
: