Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShaderLab ignore Editor module #2395

Merged
merged 162 commits into from
Nov 15, 2024

feat: add unitest

2749c76
Select commit
Loading
Failed to load commit list.
Merged

ShaderLab ignore Editor module #2395

feat: add unitest
2749c76
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 15, 2024 in 0s

66.88% (+0.04%) compared to 14027ac

View this Pull Request on Codecov

66.88% (+0.04%) compared to 14027ac

Details

Codecov Report

Attention: Patch coverage is 61.53846% with 10 lines in your changes missing coverage. Please review.

Project coverage is 66.88%. Comparing base (14027ac) to head (2749c76).

Files with missing lines Patch % Lines
...hader-lab/src/contentParser/ShaderContentParser.ts 60.00% 4 Missing ⚠️
packages/shader-lab/src/ShaderLab.ts 33.33% 2 Missing ⚠️
...ckages/shader-lab/src/parser/ShaderTargetParser.ts 33.33% 2 Missing ⚠️
packages/shader-lab/src/preprocessor/PpParser.ts 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           dev/1.4    #2395      +/-   ##
===========================================
+ Coverage    66.84%   66.88%   +0.04%     
===========================================
  Files          897      897              
  Lines        92617    92597      -20     
  Branches      7341     7347       +6     
===========================================
+ Hits         61906    61930      +24     
+ Misses       30465    30421      -44     
  Partials       246      246

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov