Disable glsl compress for non-mini package #2469
Conversation
Sway007
added
shader
WalkthroughThe pull request modifies the Rollup configuration by introducing a new Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
rollup.config.js (2)
34-37: LGTM! Consider documenting the plugin configuration.The base configuration for GLSL processing is well-structured and correctly disables compression by default.
Consider adding a comment explaining why compression is disabled by default and when it gets enabled.
Line range hint
34-104: Consider restructuring plugin configuration management.The current implementation mixes build configuration with plugin configuration. Consider:
- Extract plugin configurations to a separate file (e.g.,
rollup.plugins.js)- Create a factory function for glslify plugin configuration:
// rollup.plugins.js function createGlslifyPlugin({ compress = false } = {}) { return glslify({ include: [/\.(glsl|gs)$/], compress }); } export const plugins = { base: createGlslifyPlugin(), compressed: createGlslifyPlugin({ compress: true }) };This would make the configuration more maintainable and the compression settings more explicit.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
rollup.config.js(2 hunks)
🔇 Additional comments (1)
rollup.config.js (1)
41-41: LGTM! Plugin placement is correct.
The glslifyPlugin is appropriately positioned in the plugin chain, ensuring shader processing occurs before transpilation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/1.4 #2469 +/- ##
===========================================
- Coverage 68.27% 67.70% -0.58%
===========================================
Files 911 911
Lines 94585 94514 -71
Branches 7937 7942 +5
===========================================
- Hits 64582 63992 -590
- Misses 29752 30270 +518
- Partials 251 252 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Summary by CodeRabbit
New Features
Bug Fixes