Fix characterController create error #2508
Conversation
luzhuang
added
physics
WalkthroughThis pull request involves two distinct changes: updating the source URL for the PhysX library in the WebAssembly runtime mode and modifying a test case for the Changes
Sequence Diagram(s)No sequence diagram is necessary for these changes, as they are relatively simple modifications to a script URL and a test case. Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/src/core/physics/CharacterController.test.ts (1)
286-288: Consider adding a complementary test case.To ensure comprehensive coverage of controller state transitions, consider adding a test case that:
- Sets shape properties while the controller is enabled
- Disables the controller
- Verifies the properties persist in disabled state
Example test case:
it("update shape data when enabled", () => { const controller = roleEntity.getComponent(CharacterController); controller.enabled = true; controller.clearShapes(); const capsuleColliderShape = new CapsuleColliderShape(); controller.addShape(capsuleColliderShape); capsuleColliderShape.contactOffset = 0.1; capsuleColliderShape.radius = 0.2; capsuleColliderShape.height = 1; controller.enabled = false; expect(capsuleColliderShape.contactOffset).eq(0.1); expect(capsuleColliderShape.radius).eq(0.2); expect(capsuleColliderShape.height).eq(1); });
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
packages/physics-physx/libs/physx.release.wasmis excluded by!**/*.wasm
📒 Files selected for processing (2)
packages/physics-physx/src/PhysXPhysics.ts(1 hunks)tests/src/core/physics/CharacterController.test.ts(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/physics-physx/src/PhysXPhysics.ts
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: build (22.x, windows-latest)
- GitHub Check: e2e (22.x)
- GitHub Check: codecov
🔇 Additional comments (1)
tests/src/core/physics/CharacterController.test.ts (1)
286-288: LGTM! Important test coverage improvement.The added line ensures that shape modifications made while the controller is disabled persist after re-enabling it. This is crucial for verifying the correct handling of shape data during controller state transitions.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/1.4 #2508 +/- ##
===========================================
- Coverage 68.53% 68.52% -0.01%
===========================================
Files 957 957
Lines 100057 100041 -16
Branches 8552 8542 -10
===========================================
- Hits 68575 68558 -17
- Misses 31226 31227 +1
Partials 256 256
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Summary by CodeRabbit