-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ensure liquidity mining NFT id is within reserved range #444
Conversation
Runtime version has not been increased. |
Codecov Report
@@ Coverage Diff @@
## master #444 +/- ##
==========================================
+ Coverage 84.02% 84.04% +0.01%
==========================================
Files 26 26
Lines 3093 3096 +3
==========================================
+ Hits 2599 2602 +3
Misses 494 494
Continue to review full report at Codecov.
|
@Roznovjak can you add test that check works like expected? |
A test is automatically generated from it. But it's more like a verification, because testing it (both scenarios) would require two runtimes with different pallet configurations. |
when it actually panics? after runtime upgrade? |
It looks like it behaves just like a normal test. Ref |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found the test: test mock::__construct_runtime_integrity_test::runtime_integrity_tests ... ok
LGTM
Fixes: #427