feat: support assets with xyk dot pools as fee asset #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Crate versions that have been updated:
Runtime version has been increased. |
… and use the same amount out for buyfor swap
…icient-asset-in-dca # Conflicts: # pallets/dca/src/tests/on_initialize.rs # pallets/dca/src/weights.rs # runtime/hydradx/src/weights/pallet_dca.rs
dmoka
changed the title
dmoka
changed the title
…icient-asset-in-dca # Conflicts: # Cargo.lock # integration-tests/Cargo.toml # traits/Cargo.toml
…icient-asset-in-dca # Conflicts: # Cargo.lock # integration-tests/Cargo.toml # pallets/liquidity-mining/Cargo.toml # pallets/xyk/Cargo.toml
| .ok_or(ArithmeticError::Overflow)?; | ||
| Self::unallocate_amount(schedule_id, schedule, effective_amount_in)?; | ||
|
|
||
| let fee_in_dot = Self::convert_to_polkadot_native_asset(Self::weight_to_fee(weight_to_charge))?; |
There was a problem hiding this comment.
do you need to do this again ?
should not this be equal to fee_amount_in_sold_asset?
There was a problem hiding this comment.
fee_amount_in_sold_asset is different from fee_in_dot.
Because the amount_in (so DCA fee asset) is not necessarly DOT.
But we need to calculate the fee_in_dot, so we know how much we should do a buy trade for, within the FeeAsset-DOT xyk pool
enthusiastmartin
approved these changes
Sep 23, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about:
*A non-fee payment asset is any asset whose price is not calculated within the multi-payment pallet. For example we also want to support WUD which is a sufficient asset but not tracked in multi pallets.
TODO:
ExtrinsicBaseWeightwithdraw_fee(used forExtrinsicBaseWeight) on reference machine(Benchmark withdraw_fee and check if it is not bigger than
ExtrinsicBaseWeight. If so, then adjust. "The base weight contains all the shit for validating tx and doing all the on initialize and other stuff for every transaction so we should probably increase it anyway... But there should be a guide on how to bench this from shawn somewhere I think")