feat: ERC20 currency binding #899
Conversation
|
New crates:
Crate versions that have been updated:
Runtime version has been increased. |
| provenance, | ||
| ) | ||
| match T::BoundErc20::contract_address(asset) { | ||
| Some(_) => DepositConsequence::UnknownAsset, |
There was a problem hiding this comment.
why there is unknown asset here ? as it seems to be clearly known. similar questions for other methods too.
There was a problem hiding this comment.
CannotCreate would be better?
There was a problem hiding this comment.
i am not sure what else to choose from WithdrawConsequences
There was a problem hiding this comment.
this would be resolved by just supporting deposits i guess
| @@ -758,6 +761,24 @@ impl<T: Config> Create<Balance> for Pallet<T> { | |||
| } | |||
| } | |||
|
|
|||
| impl<T> BoundErc20 for Pallet<T> | |||
There was a problem hiding this comment.
i would not implement this for the pallet. I'd consider having something in our adapters that does this.
There was a problem hiding this comment.
i remember why is here ... as it completely relies on local functions - asset registry storages (asset type & location) and it is very tightly bound to it, i don't really see any advantage of moving it out now
There was a problem hiding this comment.
also i would like to add new extrinsic to asset registry to register these erc20 by specifying contract address (basically write version of this function)
There was a problem hiding this comment.
+1 for not having this in the pallet
| @@ -197,7 +226,13 @@ where | |||
| if asset == T::GetNativeCurrencyId::get() { | |||
| <T::NativeCurrency as fungible::Mutate<T::AccountId>>::mint_into(who, amount.into()).into() | |||
| } else { | |||
| <T::MultiCurrency as fungibles::Mutate<T::AccountId>>::mint_into(asset.into(), who, amount.into()).into() | |||
| match T::BoundErc20::contract_address(asset) { | |||
| Some(_) => fail!(Error::<T>::NotSupported), | |||
There was a problem hiding this comment.
why not supported?
in the implementaiton of multicurrecny, you call deposit in case of deposit ( mint ).
There was a problem hiding this comment.
if you check implementation of Erc20Currency that yields unsupported as well, mby cleaner would be to call deposit implementation from multicurrency here as well?
There was a problem hiding this comment.
more interesting would be to support deposit and withdraw by using some holding account (withdraw transfers to holding, deposit transfers from holding)
# Conflicts: # Cargo.lock # integration-tests/Cargo.toml # pallets/route-executor/Cargo.toml
Co-authored-by: Daniel Moka <mokabme@gmail.com>
# Conflicts: # Cargo.lock # integration-tests/Cargo.toml # runtime/hydradx/Cargo.toml # runtime/hydradx/src/lib.rs
# Conflicts: # Cargo.lock # integration-tests/Cargo.toml # pallets/dca/Cargo.toml # pallets/liquidity-mining/Cargo.toml # pallets/route-executor/Cargo.toml # pallets/transaction-multi-payment/Cargo.toml # pallets/xyk-liquidity-mining/Cargo.toml # pallets/xyk/Cargo.toml # runtime/hydradx/Cargo.toml # traits/Cargo.toml
…tom code implementation there
# Conflicts: # integration-tests/src/contracts.rs
…need to reinmplement the whole frontier runner and executer which comes with too much work
# Conflicts: # Cargo.lock # integration-tests/Cargo.toml # runtime/hydradx/Cargo.toml # runtime/hydradx/src/lib.rs
# Conflicts: # Cargo.lock # Cargo.toml # integration-tests/Cargo.toml # node/Cargo.toml # pallets/asset-registry/Cargo.toml # pallets/claims/Cargo.toml # pallets/currencies/Cargo.toml # pallets/evm-accounts/Cargo.toml # pallets/otc-settlements/Cargo.toml # pallets/otc/Cargo.toml # primitives/Cargo.toml # runtime/hydradx/Cargo.toml # runtime/hydradx/src/evm/evm-utility/Cargo.toml # runtime/hydradx/src/lib.rs # runtime/hydradx/src/weights/pallet_currencies.rs # runtime/hydradx/src/weights/pallet_evm_accounts.rs
# Conflicts: # Cargo.lock # runtime/hydradx/Cargo.toml # runtime/hydradx/src/lib.rs
# Conflicts: # Cargo.toml
provides the ability for currencies pallet (and fungibles trait) to operate with the ERC20 contracts deployed in EVM
also allowed contracts can operate with substrate currencies through ERC20 precompiles
wip todo
future todo