feat: unified trade events #910
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jak-pan
reviewed
Sep 20, 2024
| @@ -747,7 +757,7 @@ pub mod pallet { | |||
| /// - `amount`: The amount of `asset_out`. | |||
| /// - `max_limit`: maximum amount of `asset_in` to be sold in exchange for `asset_out`. | |||
| /// | |||
| /// Emits `BuyExecuted` when successful. | |||
| /// Emits `pallet_trade_event::Swapped` when successful. | |||
jak-pan
reviewed
Sep 20, 2024
| @@ -1111,6 +1127,18 @@ impl<T: Config> AMM<T::AccountId, AssetId, AssetPair, BalanceOf<T>> for Pallet<T | |||
| fee_amount: transfer.fee.1, | |||
| }); | |||
|
|
|||
| pallet_trade_event::Pallet::<T>::deposit_trade_event( | |||
| transfer.origin.clone(), | |||
There was a problem hiding this comment.
I am thinking to add second account because of the Intents... We might have 2 accounts trading directly. cc @enthusiastmartin wdyt?
There was a problem hiding this comment.
Also easier to track when if have multiple pools with same assets
jak-pan
reviewed
Sep 20, 2024
| transfer.amount, | ||
| transfer.amount_b, | ||
| vec![transfer.fee], | ||
| None, |
jak-pan
reviewed
Sep 20, 2024
| /// Amount of the Hub asset has been updated. | ||
| HubAmountUpdated { | ||
| hub_amount_in: Balance, | ||
| hub_amount_out: Balance, |
There was a problem hiding this comment.
batch-id? (I would probably rename it to event-id or something similar)
jak-pan
reviewed
Sep 20, 2024
| ); | ||
|
|
||
| Ok(()) | ||
| Self::do_sell(origin, asset_in, asset_out, amount, min_buy_amount, None) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #755