Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Added report generation and uploading , upgraded gradle version #50

Merged
merged 23 commits into from
Aug 20, 2024

Conversation

jaydee029
Copy link
Contributor

For Issue galasa-dev/projectmanagement#1965
Successful PR run for this is here

jaydee029 and others added 15 commits August 20, 2024 15:49
Signed-off-by: dhruv <dhruvj797@gmail.com>
Signed-off-by: dhruv <dhruvj797@gmail.com>
Signed-off-by: dhruv <dhruvj797@gmail.com>
Signed-off-by: dhruv <dhruvj797@gmail.com>
Signed-off-by: dhruv <dhruvj797@gmail.com>
Signed-off-by: dhruv <dhruvj797@gmail.com>
Signed-off-by: dhruv <dhruvj797@gmail.com>
Signed-off-by: dhruv <dhruvj797@gmail.com>
Signed-off-by: dhruv <dhruvj797@gmail.com>
Signed-off-by: dhruv <dhruvj797@gmail.com>
Signed-off-by: dhruv <dhruvj797@gmail.com>
Signed-off-by: dhruv <dhruvj797@gmail.com>
Signed-off-by: dhruv <dhruvj797@gmail.com>
Signed-off-by: dhruv <dhruvj797@gmail.com>
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

jaydee029 and others added 2 commits August 20, 2024 17:59
Signed-off-by: dhruv <dhruvj797@gmail.com>
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please upgrade Java to 17 and remove the Jacoco step and this will be ready - thanks

.github/workflows/build.yaml Outdated Show resolved Hide resolved
jaydee029 and others added 2 commits August 20, 2024 19:22
Signed-off-by: dhruv <dhruvj797@gmail.com>
removing jacoco report step
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

jaydee029 and others added 2 commits August 20, 2024 19:59
Signed-off-by: dhruv <dhruvj797@gmail.com>
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but missing the upgrade of the Java version

jaydee029 and others added 2 commits August 20, 2024 20:48
Signed-off-by: dhruv <dhruvj797@gmail.com>
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for building

@galasa-team
Copy link

Build successful

@jadecarino jadecarino merged commit 358afa5 into galasa-dev:main Aug 20, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants