Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration rebuild. #15155

Closed
wants to merge 1 commit into from
Closed

Conversation

dannon
Copy link
Member

@dannon dannon commented Dec 8, 2022

Not exactly sure when this got out of sync looking at the immediate history, but this popped up in another context as needing a rebuild.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@dannon dannon marked this pull request as ready for review December 8, 2022 18:22
@martenson
Copy link
Member

we should have a CI for this

# Leave at the default value to require authorization at upload creation time.
# This means Galaxy's web process does not need to be running after creating the initial
# upload request.
#
#

This comment was marked as resolved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess standard

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 I just did make config-rebuild

@mvdbeek
Copy link
Member

mvdbeek commented Dec 8, 2022

huh, this is reverting nate's changes ... are you on a recent dev ?

@dannon
Copy link
Member Author

dannon commented Dec 8, 2022

Swapped to draft -- it looks like this was a lot in #15017

@dannon
Copy link
Member Author

dannon commented Dec 8, 2022

@mvdbeek Yeah, I just saw that too when I went to track down where it came from. None of that is in the schema and gets overwritten on the latest dev for me -- how is this supposed to be handled?

@nsoranzo
Copy link
Member

nsoranzo commented Dec 8, 2022

@dannon Did you update your .venv with the latest gravity?

@dannon
Copy link
Member Author

dannon commented Dec 8, 2022

@nsoranzo Ah-ha! Let me try that. I see in config_manage where it should be pulling that in now.

@dannon
Copy link
Member Author

dannon commented Dec 8, 2022

Fancy configuration merging there, I just learned something -- thanks @nsoranzo

@dannon dannon closed this Dec 8, 2022
@dannon dannon deleted the configrebuild branch December 8, 2022 19:04
@github-actions github-actions bot added this to the 23.0 milestone Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants