[23.1] Remove render.py script from iSEE #16616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Thanks, it's nice not to import from the script while templating, however this shouldn't be breaking pulsar AFAICT, it's all templated in the job handler and the script doesn't even need to be transferred ... what problem was this causing @bgruening ?
mvdbeek
changed the title
|
The IT was not starting as the file "job_working_dir/.../isee/render.py" could not be found. It was not staging the file. I tried required_files¶ but it did not work. But I admit I only tried it for 30min or so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the unnecessary external python script to allow @bgruening to run this on pulsar.
License