Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split linters in separate classes #17081

Merged
merged 34 commits into from
Feb 16, 2024
Merged
Changes from 2 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
8eb0ef0
split stdio linters in separate classes
bernt-matthias Nov 24, 2023
0fbe617
remove linter code and fixes
bernt-matthias Nov 25, 2023
8d43947
split general and citations linter
bernt-matthias Nov 25, 2023
dd2a388
split command linter
bernt-matthias Nov 26, 2023
7b3d38c
make xml_order a Linter
bernt-matthias Nov 26, 2023
350a439
split help linters
bernt-matthias Nov 26, 2023
bf340a5
started with test linters
bernt-matthias Dec 1, 2023
3bccffc
split test linters
bernt-matthias Dec 4, 2023
5ae6594
split output linters
bernt-matthias Dec 4, 2023
d357ad0
split input linters
bernt-matthias Dec 5, 2023
ca364d1
add lxml based xml schema check
bernt-matthias Dec 7, 2023
5ef5651
do not print linter info
bernt-matthias Dec 7, 2023
7817fe1
run xsd linter in all linter unit tests
bernt-matthias Dec 7, 2023
c3a93e5
some fixes for xsd
bernt-matthias Dec 7, 2023
aac06ac
Fix unit test assertion
mvdbeek Dec 8, 2023
1a25ef6
skip validation of upload tool
bernt-matthias Dec 8, 2023
3d09584
remove fix method from linters
bernt-matthias Dec 8, 2023
212acf3
do not lint with ABC
bernt-matthias Dec 13, 2023
7e0b77c
some fixes
bernt-matthias Dec 13, 2023
6da7809
fix: allow options/column in data parameters
bernt-matthias Dec 13, 2023
c74f066
remove InputsSelectOptionTextMissing
bernt-matthias Dec 13, 2023
12f69be
allow macro
bernt-matthias Dec 14, 2023
584464e
add linter to lint context output
bernt-matthias Dec 15, 2023
0bb8c72
split cwl linters
bernt-matthias Dec 15, 2023
62adedb
allow options element in tool
bernt-matthias Dec 17, 2023
555fe5f
try source_path() instead of _source_path
bernt-matthias Dec 17, 2023
ccced2f
add function to list available linters
bernt-matthias Jan 15, 2024
3a98a3a
implement listing of linters
bernt-matthias Jan 17, 2024
2428b9d
Merge branch 'dev' into topic/linter-overhaul
bernt-matthias Feb 15, 2024
46ff3f2
use types-lxml instead of lxml-stubs
bernt-matthias Feb 15, 2024
368f3e8
Revert "use types-lxml instead of lxml-stubs"
bernt-matthias Feb 15, 2024
ed8eb6e
Add type ignore
bernt-matthias Feb 15, 2024
a0b25b5
new lines
bernt-matthias Feb 15, 2024
101a8a9
Merge branch 'topic/linter-overhaul' of https://github.com/bernt-matt…
bernt-matthias Feb 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/galaxy/tool_util/linters/xsd.py
Original file line number Diff line number Diff line change
@@ -25,7 +25,7 @@ def lint(cls, tool_source: "ToolSource", lint_ctx: "LintContext"):
xmlschema = etree.parse(TOOL_XSD)
xsd = etree.XMLSchema(xmlschema)
if not xsd.validate(tool_xml):
for error in xsd.error_log:
for error in xsd.error_log: # type: ignore[attr-defined] # https://github.com/lxml/lxml-stubs/pull/100
# the validation error contains the path which allows
# us to lookup the node that is reported in the lint context
node = tool_xml.xpath(error.path)